Repository navigation
SCCP: Fold array_key_exists() with boolean and integral float keys - #25436
Merged
Merged
Conversation
ndossche
approved these changes
Nov 13, 2026
| <?php | ||
| function test() { | ||
| var_dump( | ||
| array_key_exists(true, [1 => null]), |
Member
There was a problem hiding this comment.
Please add a test with NAN and null as the first argument, it must not be evaluated at compile time.
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can remove the extra key-type restriction in ct_eval_array_key_exists() to allow SCCP to fold calls with boolean and integral float keys
This is safe because fetch_array_elem()
php-src/Zend/Optimizer/sccp.c
Lines 361 to 388 in d1ec606
already implements the required conversions.
for example:
before
after