Skip to content

Preview package completions inline while typing - #29

Merged
nebuff merged 3 commits into
mainfrom
25-typing-time-completion-preview-where-it-is-cheap
Oct 25, 2026
Merged

nebuff merged 3 commits into
mainfrom
25-typing-time-completion-preview-where-it-is-cheap

Conversation

@nebuff

@nebuff nebuff commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

What

Shows the rest of a package-provided argument candidate inline in the dim
suggestion colour while the argument is typed: preview al reads as
preview alpha, and → / End / Ctrl-F accept it. Only the in-memory
completion table is consulted, so typing never runs package code or touches
the filesystem (Tab completion still lists every match).

  • src/packages/lua_api.rs — completion_preview() returns the suffix of the
    first matching candidate, in the same order Tab lists them.
  • src/main.rs — package_completion_hint() previews the word at the cursor
    and falls back to the history suggestion when no candidate matches.
  • docs/packages.md — documents the preview for package authors.

Reconciliation

The branch was cut from v1.1.3 and had unresolved conflict markers committed
in src/main.rs
, so GitHub reported it as unmergeable. main has been
merged in and the conflict resolved by keeping main's inline-hint,
history-picker and syntax-highlighting wiring, then layering this feature on
top. The branch now differs from main by only these three files.

Verification

  • cargo test: 101 tests pass
  • cargo build --release: clean
  • PTY run against the real binary with a test package: preview, acceptance,
    execution, history fallback, plus the history-popup regression suite
  • New CI workflow runs cargo test + cargo build --release — check is green

Closes #25

🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com

@nebuff nebuff self-assigned this Oct 25, 2026
@nebuff nebuff linked an issue Oct 25, 2026 that may be closed by this pull request
nebuff and others added 2 commits October 25, 2026 11:15
The branch was cut from v1.1.3 and had committed unresolved conflict
markers in src/main.rs, so it neither built nor merged. Resolve by
keeping main's inline-hint, history-picker and syntax-highlighting
wiring and layering the package completion preview from issue #25 on
top of it.

Co-Authored-By: Codebuff <noreply@codebuff.com>
The repository had no workflow at all, so pull requests carried no
checks. This mirrors the two gates the project already asks
contributors to run locally: cargo test and cargo build --release.

Co-Authored-By: Codebuff <noreply@codebuff.com>
@nebuff nebuff changed the title Had an AI Agent go through changes add some code comments Preview package completions inline while typing Oct 25, 2026
@nebuff
nebuff merged commit d054907 into main Oct 25, 2026
1 check passed
@nebuff
nebuff deleted the 25-typing-time-completion-preview-where-it-is-cheap branch October 25, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing-time completion preview where it is cheap (Verify)

1 participant