Repository navigation
Check e2e outcomes of the RAxML binaries against per-host fixtures - #507
Merged
Merged
Conversation
Replaces the file-existence e2e specs with one spec that runs ModelTest, raxml-ng and raxmlHPC on the example alignment and compares model, score and best tree with fixtures measured on darwin-arm64, linux-x64 and win32-x64. Newick and output-parsing helpers are covered by Jest tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raxml-ng and raxmlHPC run with the model the app fills in from the ModelTest result, with a pinned seed.
yarn test:e2e:update-fixturesregenerates the current host's fixtures. No change undersrc.Evidence
After: a changed model, score or topology fails with expected, actual, delta and tolerance. Jest: 4 suites, 17 tests pass for the Newick and parsing helpers. The Playwright e2e runs on macOS, Ubuntu and Windows in this PR's CI.
Merge Danger
Door: two-way
Blast Radius: e2e CI only
Fixtures are tied to the bundled binaries; a binary update needs regenerated fixtures. The Linux ModelTest-NG and raxml-ng binaries report
x.y.zand1.2.2-master, which the spec declares per host.🤖 Generated with Claude Code