Skip to content

Check e2e outcomes of the RAxML binaries against per-host fixtures - #507

Merged
jtklein merged 1 commit into
AntonelliLab:masterfrom
jtklein-agents:spec/214-upstream
Nov 16, 2026
Merged

jtklein merged 1 commit into
AntonelliLab:masterfrom
jtklein-agents:spec/214-upstream

Conversation

@jtklein-agents

Copy link
Copy Markdown
Contributor

Summary

 e2e/
-├── modeltest-then-raxml-ng.spec.js   # file existence, loose tree check
-├── raxmlHPC.spec.js
+├── modeltest-outcome.spec.js         # one launch: ModelTest -> raxml-ng TI -> raxmlHPC ML
 ├── helpers/
+│   ├── newick.js                     # parse, RF distance, branch lengths
+│   ├── {modeltest,raxmlNg,raxmlHpc}Outcome.js
+│   └── fixtures.js                   # compare against, or write, the host fixture
 └── fixtures/
+    ├── darwin-arm64/
+    ├── linux-x64/
+    └── win32-x64/                    # no raxml-ng (no Windows binary)
checkFixture(name, settings, actual)
  if RAXMLGUI_UPDATE_FIXTURES      write fixtures/<host>/<name>.json
  else                             compare: topology exact, scores 1e-4, branch lengths 1e-3
                                   on drift: one block per field, fixture path, regenerate command

raxml-ng and raxmlHPC run with the model the app fills in from the ModelTest result, with a pinned seed. yarn test:e2e:update-fixtures regenerates the current host's fixtures. No change under src.

Evidence

  • Before: the e2e checked that output files exist and the tree had taxon names; a changed score or wrong model still passed.
    After: a changed model, score or topology fails with expected, actual, delta and tolerance. Jest: 4 suites, 17 tests pass for the Newick and parsing helpers. The Playwright e2e runs on macOS, Ubuntu and Windows in this PR's CI.

Merge Danger

Door: two-way

Blast Radius: e2e CI only

Fixtures are tied to the bundled binaries; a binary update needs regenerated fixtures. The Linux ModelTest-NG and raxml-ng binaries report x.y.z and 1.2.2-master, which the spec declares per host.

🤖 Generated with Claude Code

Replaces the file-existence e2e specs with one spec that runs ModelTest, raxml-ng
and raxmlHPC on the example alignment and compares model, score and best tree
with fixtures measured on darwin-arm64, linux-x64 and win32-x64. Newick and
output-parsing helpers are covered by Jest tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jtklein
jtklein merged commit 868c7d3 into AntonelliLab:master Nov 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants