Repository navigation
Fix missing Facebook profile share button - #14754
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/fb/sharepage can show its heading without any usable share control. Replace the injected v3.0 Facebook SDK widget with a normal button linking to Meta’s supported Share Dialog, using the configured app ID and the signed-in user’s public profile URL. The control renders as soon as account data is available and no longer depends on one-time SDK parsing.Logged-out visitors get a sign-in link, and the page always exposes the public privacy policy.
Validation: two focused component tests pass (logged-out access and share-link rendering after account data becomes available); repository ESLint/formatting and
git diff --checkpass. Opened the real Share Dialog with Audius’s production app ID and verified the Facebook composer loads. No Facebook post was published.Reference: https://developers.facebook.com/documentation/sharing/reference/share-dialog