Repository navigation
Change customised_axes arg to str axes arg - #489
Merged
Merged
Conversation
harryswift01
approved these changes
Nov 12, 2026
harryswift01
left a comment
Member
There was a problem hiding this comment.
This looks like a great addition to ensure that users are able to choose their own axes when running a CodeEntropy calculation. It looks like everything has now been accounted for and the unit and regression tests as well as the docs have been updated so I'm happy to see this merge, thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the boolean customised_axes argument to the string axes argument that can take the values "local", "principal" and "topology". This closes issue #426.
Changes
Testing
Impact
Checklist
pyproject.tomlchanged, the lower bounds were reviewed deliberately