Repository navigation
Add a --json option to write structured results - #101
Merged
harryswift01 merged 6 commits intoNov 16, 2026
Merged
harryswift01 merged 6 commits into
harryswift01 merged 6 commits into
Conversation
4 tasks
harryswift01
force-pushed
the
96-feature-write-structured-json-results-from-sist
branch
2 times, most recently
from
November 12, 2026 15:54
a73613b to
e2cd21c
Compare
--json option to write structured results
harryswift01
force-pushed
the
96-feature-write-structured-json-results-from-sist
branch
from
November 16, 2026 14:45
496cc49 to
baa5ccb
Compare
jimboid
approved these changes
Nov 16, 2026
jimboid
left a comment
Member
There was a problem hiding this comment.
Missed this RR, happy for this to merge, its all very self explanatory.
harryswift01
deleted the
96-feature-write-structured-json-results-from-sist
branch
November 16, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
--json FILEoption tosistthat writes the result of a run as structured JSON, checked against the result schema. Closes #96. Refs #26, #27, #28.Changes
--json FILEtosist. With--jsonalone only the JSON is written. With-oas well, the text output is also written from a second qsidd run without full precision, so it matches the existing output.-b -p -r -Pfor JSON, build the result withsist.resultsand check it withResultValidatorbefore writing.SistRunnertake the IR scorer, qsidd executor and result writer as arguments, with the existing behaviour as the default.test_cli.pyand the separate JSON and parser-based regression tests are replaced.cli.py,python -m sistand the runner's real collaborators.Testing
Impact
--jsonoption. Without it, behaviour and output are unchanged.null.22-docs-*) describe the old result layout and will be redone in the follow-up that regenerates the examples.Checklist
pyproject.tomlchanged, the lower bounds were reviewed deliberately