Repository navigation
fix(app): landing agent card keeps its height when the chat has history (CLEAN-219) - #180
Merged
maksymhryzodub-prog merged 1 commit intoNov 11, 2026
Conversation
…ry (CLEAN-219) The card is a grid 480px high with an implicit auto row. An auto row grows with its content, so a conversation with real history stretched the chat column to the height of the whole history; the card clipped it and the composer and the side buttons fell below its edge. The row is now pinned to the card height and the column may shrink, so the message list scrolls inside. On narrow screens, where the card has no height of its own, the chat view gets one. Twin check: admin has no landing, nothing to change there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://dreamvention.atlassian.net/browse/CLEAN-219
What was wrong
On the landing, the agent card looked right only while its chat was empty. With real history the chat column grew to the height of the whole conversation, the 480px card clipped it, and the composer and the side buttons disappeared below its edge.
Cause: the card is a grid with an implicit
autorow, which grows with its content.Fix
CSS only, in
app/slices/common/components/landing/hero/Stage.vue:grid-template-rows: minmax(0, 1fr)) and the chat column may shrink, so the message list scrolls inside the card;Checked
Filled the landing chat with a long history in the browser (40 blocks, 2883px of content):
Unit tests and typecheck were not re-run for this CSS-only change; CI covers them.
Twin consoles
adminhas no landing; nothing to change there.