Skip to content

Fix UAuthUrlBuilder when Tenant Specified - #145

Merged
mckaragoz merged 4 commits into
CodeBeamOrg:devfrom
mckaragoz:FixUrlBuilder
Nov 6, 2026
Merged

mckaragoz merged 4 commits into
CodeBeamOrg:devfrom
mckaragoz:FixUrlBuilder

Conversation

@mckaragoz

@mckaragoz mckaragoz commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix incorrect URL construction when route-based multi-tenancy is enabled and the client uses an absolute endpoint base URL.

Changes

  • Preserve the scheme, host, and port when inserting tenant segments into absolute URLs.
  • Correctly position the tenant before the authentication base path.
  • Validate and encode tenant route segments.
  • Preserve existing behavior for disabled tenancy and non-route transports.
  • Add regression tests covering relative and absolute URLs, transport modes, and invalid tenant values.

No breaking API changes.

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.81%. Comparing base (abad249) to head (71f56db).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...imateAuth.Client/Infrastructure/UAuthUrlBuilder.cs 75.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #145      +/-   ##
==========================================
- Coverage   87.38%   86.81%   -0.58%     
==========================================
  Files         717      726       +9     
  Lines       20212    20358     +146     
  Branches     2464     2471       +7     
==========================================
+ Hits        17663    17674      +11     
- Misses       1769     1787      +18     
- Partials      780      897     +117     
Flag Coverage Δ
framework 86.81% <75.00%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mckaragoz
mckaragoz merged commit 9493830 into CodeBeamOrg:dev Nov 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant