Repository navigation
fix: keep councils apart in geogrid maps, and improve the README - #2
Merged
Merged
Conversation
added 3 commits
November 10, 2026 16:23
geogrid matched areas to hexagons by distance alone, so areas near the border landed in the other council. scripts/hex.R now keeps geogrid's grid but does the matching itself, one council at a time, and repairs stray hexagons. Single-council results are unchanged area by area. The new matching runs once instead of once per area, so geogrid is now built for Output Areas as well (84 map files, up from 75). Also rebuilds swansea-oa-2001-hexmap, which predated the geometry repair.
|
good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scripts/hex.Rnow keeps geogrid's grid but does the matching itself, one council at a time, and repairs stray hexagons.How it was checked
bun run typecheckbun run check: all 84 map files, their images and the sample data are in stepbun run site:build, and the geogrid Output Area map looked right in headless ChromeNotes for the reviewer
swansea-oa-2001-hexmap.jsonalso changed: it predated the geometry repair inscripts/hex.R, and the rebuild made it consistent.