Repository navigation
comline fix: apply the language's fixes and move editions - #143
Merged
Merged
Conversation
added 3 commits
November 9, 2026 11:37
…r edition core#102. `comline fix` applies the fixes core attaches to its edition diagnostics: a config.idp without specification_version gets the line, and each use of a word the package's edition deprecates or removes is replaced when it has a replacement (others are listed to change by hand). `--edition N` checks and fixes the schemas under edition N and moves config.idp to it, unless a removed word without a replacement is left. `--dry-run` lists the fixes without writing. The edition-change line in build and diff now says it bumps nothing by itself, matching core.
…ons cascade core b933209 (core#217), generation bb89a51, comline-rust de0b8e5, comline-typescript 9952c5a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cli side of ComlineProject/core#102. Core's part is in ComlineProject/core#217.
comline fix [--edition N] [--dry-run]config.idpwithoutspecification_versiongets the line;--edition N:config.idpto N;--dry-runlists the fixes and writes nothing.src/**/*.idsand edits onlyconfig.idpand schemas.Also changed:
changes.rsnow says an edition move bumps nothing by itself, matching core.Pins: core
b933209, generationbb89a51, comline-rustde0b8e5, comline-typescript9952c5a.comline-doc-markdownandcomline-doc-htmlmove to generationbb89a51too. They reach core through codegen, so leaving them behind split core into two crates (E0308).Tested
set_editionreplaces only the number, schemas are found in nested folders in order, and several fixes apply in one file.comline newpackage with the line removed:buildfails withedition::missingand the fix;fix --dry-runwrites nothing;fixadds the line, and running it again finds nothing to fix;--edition 2is refused;buildthen passes.cargo testpasses on the final pins, 146 integration tests and 21 unit tests.Merge order: after core#217 and the generator and generation PRs. ComlineProject/docs#160 documents the command, and its CLI drift check needs this merged first.
Refs ComlineProject/core#102