Repository navigation
codegen, conformance: bump comline-core past the comline@2 path fix - #130
Merged
Merged
Conversation
…me Datagram2Framing at contract::
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves generation to core
1669a2fe4dbc5592a96a2964d7ae13e985b76701(core master after ComlineProject/core#240, which follows #239) and takes the one kernel path change from #128.codegen/Cargo.toml:comline-core(dependency and dev-dependency)b933209->1669a2f.conformance/Cargo.toml:comline-coreb933209->1669a2f.codegen/src/protocol.rs: the doc comment on the framing type namedcomline_runtime::framing::Datagram2Framing, which never existed at that path; it iscomline_runtime::contract::Datagram2Framing.No other change is needed for core#239: the doc renderers read the
@unverifiedreason from the doc model, not fromunverified::protocols().Cargo.lockis untracked here, so no lockfile change.References #128 without closing it: the regenerated goldens (
conformance/tests/golden/connections_async/rust/{conformance,connection}.rs,handshake_comline2/rust/connection.rs) come after comline-rust emits the new paths. Part of ComlineProject/runtime#111.Known: conformance does not build in this PR, by design
comline-conformancedev-depends oncomline-codegen-rust(comline-rustde0b8e5) andcomline-codegen-typescript(comline-typescript9952c5a). Both still pin coreb933209, socargo testat the workspace level resolves two copies ofcomline-coreand fails inside those two crates, not in generation's code:cargo tree -dshowscomline-core(andcomline-core-stdlib) at both1669a2fandb933209. Every error is E0308 or its note about multiple versions ofcomline_core; there is no other kind. This resolves once comline-rust and comline-typescript are bumped to core1669a2f(which pins generation at this PR's merge) and this repo's conformance dev-deps are re-pinned at their tips, together with the golden regeneration. The same intermediate state occurred in the previous editions cascade (bb89a51, fixed by311e6ae). So the "Cargo Build & Test"cargo teststep is expected to be red on this PR.Also known and left alone:
lib-gen/luaandlib-gen/luaupin coreaa84d97, andconformance/tests/golden/external_std/rustpins comline-ruste1b2167. They are unwired fixtures/stubs.Tested locally (CI's commands)
cargo build: OK.cargo test -p comline-codegen -p comline-doc-markdown -p comline-doc-html, all green: codegen 137 lib + 4comline_toml_schema+ 3doc_model; doc-html 1 lib + 9 golden; doc-markdown 1 lib + 6 golden.cargo testfor the workspace and-p comline-conformance: does not compile, for the reason above; no conformance tests ran.cargo build -p comline-codegenand the two renderers for wasm32) and the other-OS jobs.