Repository navigation
conformance: pin the generators at their reorganized-paths tips; regenerate the Rust goldens - #131
Merged
Merged
Conversation
added 2 commits
November 10, 2026 02:41
…egenerate the Rust goldens (#128)
…less external_std
Kinflou
marked this pull request as ready for review
November 9, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128. Follows generation#130 (core
1669a2f), comline-rust#116 and comline-typescript#155. Part of ComlineProject/runtime#111.What
conformance/Cargo.toml: the generator dev-deps move to the revs that share core1669a2fand name the reorganized runtime paths:comline-codegen-rust:de0b8e5->eb04c130356e44a2b88b74a6805e24d0e80bdbcc(comline-rust#116, then deps: comline-core 00fd9db (payload and output facts) #117, which repointsSTD_REV)comline-codegen-typescript:9952c5a->4cad8af36f807f395bdf83dcc29aa290187ca0d0(comline-typescript#155)This ends the two-copies-of-
comline-corebuild failure that generation#130 documented.CONFORMANCE_BLESS=1 cargo test -p comline-conformance), never by hand: only Rust ones changed, 4 files:bounds/rust/conformance.rs: the pinned runtime rev in the header comment,4f582f19->3b9cc9d.connections_async/rust/{conformance,connection}.rs: the same rev;async_connection::X->connection::X(AsyncConnection,AsyncDispatch,AsyncPeer,Answer) andtransport::AsyncTransport, which splits the oneuseinto two.handshake_comline2/rust/connection.rs:comline2::X->handshake::comline2::X(5 sites, includinguse ... as c2).No TypeScript golden changed.
external_std
conformance/tests/golden/external_std/rust/Cargo.tomlembeds comline-rust'sSTD_REV. With the pin at comline-rust#117's merge, the golden'scomline_stdrev movese1b2167->8b36b5a(re-blessed withCONFORMANCE_BLESS=1, the only change in the re-bless).The unwired
lib-gen/lua,lib-gen/luaupins (coreaa84d97) are untouched.Verification
Locally, only the golden regeneration ran (
CONFORMANCE_BLESS=1 cargo test -p comline-conformance, 3 passed); before the first bless a full workspacecargo testcompiled with a singlecomline-coreand failed only oncorpus_matches_golden. CI runs the full test.