Skip to content

conformance: pin the generators at their reorganized-paths tips; regenerate the Rust goldens - #131

Merged
Kinflou merged 2 commits into
masterfrom
conformance/regen-goldens
Nov 9, 2026
Merged

Kinflou merged 2 commits into
masterfrom
conformance/regen-goldens

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Closes #128. Follows generation#130 (core 1669a2f), comline-rust#116 and comline-typescript#155. Part of ComlineProject/runtime#111.

What

  • conformance/Cargo.toml: the generator dev-deps move to the revs that share core 1669a2f and name the reorganized runtime paths:
    • comline-codegen-rust: de0b8e5 -> eb04c130356e44a2b88b74a6805e24d0e80bdbcc (comline-rust#116, then deps: comline-core 00fd9db (payload and output facts) #117, which repoints STD_REV)
    • comline-codegen-typescript: 9952c5a -> 4cad8af36f807f395bdf83dcc29aa290187ca0d0 (comline-typescript#155)
      This ends the two-copies-of-comline-core build failure that generation#130 documented.
  • Goldens regenerated with the repo's own tooling (CONFORMANCE_BLESS=1 cargo test -p comline-conformance), never by hand: only Rust ones changed, 4 files:
    • bounds/rust/conformance.rs: the pinned runtime rev in the header comment, 4f582f19 -> 3b9cc9d.
    • connections_async/rust/{conformance,connection}.rs: the same rev; async_connection::X -> connection::X (AsyncConnection, AsyncDispatch, AsyncPeer, Answer) and transport::AsyncTransport, which splits the one use into two.
    • handshake_comline2/rust/connection.rs: comline2::X -> handshake::comline2::X (5 sites, including use ... as c2).
      No TypeScript golden changed.

external_std

conformance/tests/golden/external_std/rust/Cargo.toml embeds comline-rust's STD_REV. With the pin at comline-rust#117's merge, the golden's comline_std rev moves e1b2167 -> 8b36b5a (re-blessed with CONFORMANCE_BLESS=1, the only change in the re-bless).

The unwired lib-gen/lua, lib-gen/luau pins (core aa84d97) are untouched.

Verification

Locally, only the golden regeneration ran (CONFORMANCE_BLESS=1 cargo test -p comline-conformance, 3 passed); before the first bless a full workspace cargo test compiled with a single comline-core and failed only on corpus_matches_golden. CI runs the full test.

@Kinflou
Kinflou marked this pull request as ready for review November 9, 2026 18:49
@Kinflou
Kinflou merged commit a393c8f into master Nov 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the reorganized comline-runtime paths

1 participant