Skip to content

Pin core, generation and the generators at their reorganized tips - #104

Merged
Kinflou merged 1 commit into
masterfrom
core/keyed-unverified
Nov 9, 2026
Merged

Kinflou merged 1 commit into
masterfrom
core/keyed-unverified

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 9, 2026

Copy link
Copy Markdown
Member

Moves the language server to core 1669a2f (which has core#239: unverified::protocols() gives each reason already rendered and quoted) and to the generators that agree on it.

Pins

Crate Before After
comline-core b933209 1669a2fe4dbc5592a96a2964d7ae13e985b76701
comline-codegen (generation) bb89a51 6a73541e142ba5895fd628ee444449694382e70a
comline-codegen-rust de0b8e5 eb04c130356e44a2b88b74a6805e24d0e80bdbcc
comline-codegen-typescript 9952c5a 4cad8af36f807f395bdf83dcc29aa290187ca0d0

Generation is at 6a73541, not at generation's current master (a393c8f): comline-rust eb04c13 and comline-typescript 4cad8af pin 6a73541, and Cargo only unifies a git dependency across identical rev strings (two comline-codegen copies are two incompatible types). a393c8f differs only in generation's conformance goldens and dev-deps (generation#131). The server only reads the generators' SUPPORT tables, so the runtime reorganization doesn't touch it. Cargo.lock isn't tracked here.

Code

src/acceptance.rs: the reason now arrives rendered and quoted, so reason: reason.map(str::to_string) becomes reason, and the diagnostic's format!(": \"{r}\"") becomes format!(": {r}").

Part of ComlineProject/runtime#111; follows core#239 (and core#240, generation#130/#131, comline-rust#116/#117, comline-typescript#155). Closes no issue.

Testing

Not built or run locally; CI covers it (build, test, the wasm32 analysis library, and the cross-platform jobs).

@Kinflou
Kinflou merged commit b343471 into master Nov 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant