Repository navigation
Pin core, generation and the generators at their reorganized tips - #104
Merged
Merged
Conversation
…ake @Unverified reasons already rendered (core#239)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the language server to core
1669a2f(which has core#239:unverified::protocols()gives each reason already rendered and quoted) and to the generators that agree on it.Pins
comline-coreb9332091669a2fe4dbc5592a96a2964d7ae13e985b76701comline-codegen(generation)bb89a516a73541e142ba5895fd628ee444449694382e70acomline-codegen-rustde0b8e5eb04c130356e44a2b88b74a6805e24d0e80bdbcccomline-codegen-typescript9952c5a4cad8af36f807f395bdf83dcc29aa290187ca0d0Generation is at
6a73541, not at generation's current master (a393c8f): comline-rusteb04c13and comline-typescript4cad8afpin6a73541, and Cargo only unifies a git dependency across identical rev strings (twocomline-codegencopies are two incompatible types).a393c8fdiffers only in generation's conformance goldens and dev-deps (generation#131). The server only reads the generators'SUPPORTtables, so the runtime reorganization doesn't touch it.Cargo.lockisn't tracked here.Code
src/acceptance.rs: the reason now arrives rendered and quoted, soreason: reason.map(str::to_string)becomesreason, and the diagnostic'sformat!(": \"{r}\"")becomesformat!(": {r}").Part of ComlineProject/runtime#111; follows core#239 (and core#240, generation#130/#131, comline-rust#116/#117, comline-typescript#155). Closes no issue.
Testing
Not built or run locally; CI covers it (build, test, the wasm32 analysis library, and the cross-platform jobs).