Repository navigation
Bounds on types: re-pin core and generation, hover shows the maximum - #97
Merged
Merged
Conversation
…r shows a bound as written
added 2 commits
November 3, 2026 19:46
…t default; re-pin generation and generators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 10 of the bounds rollout (ComlineProject/core#98, ComlineProject/core#197).
8f5dc91, generationc303722, comline-rust2d50fbf, comline-typescriptea9b9e2. One copy of each inCargo.lock. The comline.toml schema and checks come from comline-codegen's shared config types at that rev.ArraySize::{Max, Exact}, so a type renders as written:char[max 32],u32[max 10],char[8], or a constant's name (char[max MAX_NAME]).bounds::unboundederrors, ascomline builddoes.Merge after ComlineProject/cli#130.
validate_on_decode(round 2): the shared schema now types it as a mode (collect, the default, orfirst) or{ off = "why" }. comline.toml checking follows aoneOfthe same way it follows ananyOf, and completion offerscollectandfirst. A bare"off"gets an error with a quick fix to{ off = "why" }, ascomline generaterefuses it.Merge after ComlineProject/generation#116, ComlineProject/comline-rust#104 and ComlineProject/comline-typescript#127, together with ComlineProject/cli#130.