Repository navigation
conformance: vendor the specification with its catalog - #114
Merged
Merged
Conversation
Re-vendors ComlineProject/specification at f219852, which adds the catalog of shared names and derives the profiles' facts and features.json from it. The CUE module moved to the specification's root, so check.sh now runs cue inside spec/, where the specs' imports resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-vendors ComlineProject/specification at
f219852(specification#1). That revision addscatalog/, the shared names of core#219, and derives the profiles' facts andfeatures.jsonfrom it.spec/now includescatalog/andcue.mod/, at the specification's root.features.jsonhas the same content and is only reformatted. No vector or profile changes, andVERSIONis still 0.10.check.shrunscueinsidespec/.specs/profile.cuenow imports the catalog, and that import only resolves inside the CUE module. I checked that it passes, and that it still fails on a brokensupport/rust.json.cueversion points at the module's new place.Tested: the conformance and reference suites, plus ffi's
vectorstest, pass with the same counts as before.vendor-spec.sh --checkandcheck.shpass.