Repository navigation
fuzz: one list of targets, the fuzz crate's [[bin]]s - #117
Merged
Merged
Conversation
The targets were written out four times: the fuzz Cargo.toml's [[bin]]s, fuzz.yml's matrix, the report's expect, and the README's table. The [[bin]]s are now the list: a fuzz targets job reads them (.github/scripts/fuzz-targets.py) for the matrix and expect, and fails unless the README's table has a row for exactly those targets.
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 of the ComlineProject/core#219 rollout, part 2: the fuzz target set, defined once. As agreed, this list belongs to the runtime, not the specification.
The eight targets were written out four times: the fuzz
Cargo.toml's[[bin]]s (which cargo-fuzz needs anyway),fuzz.yml's matrix, the report'sexpect, and the README's targets table.[[bin]]s are the list, so no separatetargets.tomlis needed: it would only be one more copy of them. No target uses tags today; one can be added to the list if a target ever needs a different schedule..github/scripts/fuzz-targets.pyreads them and prints them as JSON. It fails unlessruntime/fuzz/README.md's targets table has a row for exactly those targets. I checked that dropping a row fails it, naming the target.fuzz.yml: a newfuzz targetsjob runs the script. The matrix isfromJSONof its output, and the report'sexpectis the same list joined. Adding a target becomes one[[bin]]plus its README row.The README itself is untouched.