Repository navigation
catalog: guarantee scopes - #3
Merged
Merged
Conversation
A guarantee says which of package, protocol, function, argument, field and type may acknowledge it, from where its cause is. The schema holds the scopes to their order and to the guarantee's origin; the comline-catalog crate gains Scope, Guarantee::scopes and Guarantee::allows_scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds guarantee scopes to the catalog, for the granular
@unverifiedproposal (docs#162): where a marker acknowledging a guarantee may sit, following from where its cause is.schema_agreement,encoding_agreementversion_honestyencoding_conformancebounded_size#Scopes/#Scope(package, protocol, function, argument, field, type, outermost to innermost) and a required non-emptyscopeson#Guarantee. Two catalog checks in the style of the existing ones: scopes are in vocabulary order with no duplicates, and they follow the origin (a type-origin guarantee includestype; any other origin has nothing belowprotocol). Each was confirmed to reject a bad entry locally.sets.scopeslists the vocabulary (single source:#Scopes).comline-catalog:Scope(withas_str),Guarantee::scopes,Guarantee::allows_scope,sets::SCOPES, generated viacatalog/rust.cue; tests for scopes present and ordered,bounded_sizeallowingfieldbut notpackage, and the enum matching the set.VERSIONis not bumped: it moves for wire changes, and neither catalog PR so far (Add the catalog of shared names #1, Add the comline-catalog Rust crate #2) touched it;sinceis left unset.Generated files come from
specs/check.sh; the Rust crate was not built locally, CI covers it.