Repository navigation
Reproduction scripts for the paper, Jewett and Breslow model fixes, and testing across platforms - #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
Jewett.cbt()ignored thephi_refoffset (0.8 h) that Jewett et al. (1999) place between the minimum ofxand the temperature minimum, so every predicted dim-light melatonin onset (DLMO) was 48 minutes early. Found by comparison with thecircadianpackage; the two now agree exactly.odeintcall over the whole record then failed (after about 16 days of a regular schedule) and returned zeros for the rest of the record without raising an error.Breslow13now integrates each interval between samples separately, with an explicit Runge-Kutta fallback, and keeps pineal melatonin non-negative.Model.integrate()now raisesRuntimeErrorif the solver fails, instead of returning zeros, and rejects empty light or time input with a clear message.SyntaxWarning.Reproducibility (
paper/)circadianpackage (1.0.3) for the Forger, Jewett, Hannay (one and two populations) and Breslow models: every predicted DLMO falls on the same sample in both packages.paper/results, and a README with the exact commands and package versions.Testing
Repository
CONTRIBUTING.md: how to get help, report a bug and propose a change.CITATION.cfffilled in; contact address added toCODE_OF_CONDUCT.md.