Repository navigation
ci: cap PR risk approvals at minimal risk - #113
Open
factory-droid[bot] wants to merge 1 commit into
Open
factory-droid[bot] wants to merge 1 commit into
factory-droid[bot] wants to merge 1 commit into
Conversation
approve_risk_level: minimal, so the Droid App approves only pull requests it rates minimal; low, medium and high wait for a human. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lowers the PR risk approval cap from Low to Minimal, as Mark asked after #112 merged. Tracking: VAL-581.
.factory/review.yaml:approve_risk_level: lowbecomesapprove_risk_level: minimal, and the comment is updated. The Droid App may now approve only a pull request it rates minimal. Low, medium and high wait for a human..github/workflows/droid-review.yml: only the header comment changes, so it says Minimal. The steps don't change.Factory reads
.factory/review.yamlfrom the default branch, so the cap takes effect when this merges. Until then the Low cap from #112 applies.Testing
actionlint: clean ondroid-review.yml..factory/review.yamlchecked with Factory's rules reader: statusok, controlsriskAssessmentApprovePr: true,riskAssessmentApproveRiskLevel: minimal, approval thresholdminimal.403 workflow_not_trusted).Merge hold: Mark Attar approves and merges.