Skip to content

ci: cap PR risk approvals at minimal risk - #113

Open
factory-droid[bot] wants to merge 1 commit into
mainfrom
droid/risk-install
Open

factory-droid[bot] wants to merge 1 commit into
mainfrom
droid/risk-install

Conversation

@factory-droid

@factory-droid factory-droid Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Lowers the PR risk approval cap from Low to Minimal, as Mark asked after #112 merged. Tracking: VAL-581.

  • .factory/review.yaml: approve_risk_level: low becomes approve_risk_level: minimal, and the comment is updated. The Droid App may now approve only a pull request it rates minimal. Low, medium and high wait for a human.
  • .github/workflows/droid-review.yml: only the header comment changes, so it says Minimal. The steps don't change.

Factory reads .factory/review.yaml from the default branch, so the cap takes effect when this merges. Until then the Low cap from #112 applies.

Testing

  • actionlint: clean on droid-review.yml.
  • .factory/review.yaml checked with Factory's rules reader: status ok, controls riskAssessmentApprovePr: true, riskAssessmentApproveRiskLevel: minimal, approval threshold minimal.
  • The workflow file changes (comment only), so on this PR the review skips and Factory refuses the risk report (403 workflow_not_trusted).

Merge hold: Mark Attar approves and merges.

approve_risk_level: minimal, so the Droid App approves only pull requests
it rates minimal; low, medium and high wait for a human.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants