Repository navigation
Conversation
- Provider: add net11.0 to TargetFrameworks. No Microsoft.Extensions.Logging.Abstractions package reference is needed for net11.0: the assembly ships in the .NET 11 shared framework, and NuGet prunes the reference (the nuspec net11.0 group is empty). - Tests: multi-target FirebirdSql.Data.FirebirdClient.Tests to net10.0;net11.0 so TFM-specific code paths are exercised on both. - tests.ps1: copy the Firebird binaries into, and run the FirebirdClient suites from, every provider test TFM output. - CI: install the .NET 11 SDK (preview quality until 11.0 GA).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1302.
Summary
Adds a
net11.0target framework to the provider, and runs the provider tests on bothnet10.0andnet11.0.Changes
FirebirdSql.Data.FirebirdClient.csproj:net11.0added toTargetFrameworks. NoMicrosoft.Extensions.Logging.Abstractionspackage reference is needed fornet11.0, because on .NET 11 that assembly is part of theMicrosoft.NETCore.Appshared framework (it is in the 11.0.0-rc.3 reference pack). Thenet11.0dependency group of the built nuspec is therefore empty.FirebirdSql.Data.FirebirdClient.Tests.csproj: targetsnet10.0;net11.0, so TFM-specific code is tested on both.tests.ps1: copies the Firebird binaries into, and runs the FirebirdClient suites from, both test outputs.ci.yml: installs the .NET 11 SDK withdotnet-quality: preview. Today that resolves to 11.0.100-rc.3.26522.148, which the .NET download page labels a "go live" release.Note: CI builds with the preview SDK
With the .NET 11 SDK installed, it is the newest SDK on the runner, so CI builds the whole solution with it: the provider's net8.0/net9.0/net10.0 targets, EF Core, EF6 and the tools. The log shows
NETSDK1057: You are using a preview version of .NETfor each project.If you prefer to keep building with the .NET 10 SDK until 11.0 GA, a
global.jsoncan pin it, or this PR can wait for GA. After GA,dotnet-quality: previewshould be removed.Tests
No product code changes. The whole suite runs on both TFMs:
tests.ps1runs each FirebirdClient suite once per TFM. The log of the FB50 Default/Compression/CryptRequired job showsFirebirdClient tests (net10.0)and(net11.0), each with 648 passed and 0 failed.