Repository navigation
clean up remaining build and compiler warnings - #3344
Merged
sosnovsky merged 8 commits intoNov 18, 2026
Merged
Conversation
Read the key from the recipient queried after lookup instead of reusing the pre-lookup record, so the assertion checks that the stored key remains revoked.
Read the commit hash and branch through providers.exec to avoid deprecated process execution during configuration while preserving the debug version suffix and release branch check.
…mpiler-warnings # Conflicts: # FlowCrypt/build.gradle.kts # build.gradle.kts
DenBond7
marked this pull request as ready for review
November 17, 2026 19:12
sosnovsky
deleted the
issue_3339_Clean-up-remaining-build-and-compiler-warnings
branch
November 18, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the remaining build and compiler warnings in app code, instrumentation tests, and the Gradle build scripts.
close #3339
!!, casts, andwhenbranches. Fixed thesizeOfparameter name inEmbeddedAttachmentsProviderand theoutfield shadowing inProgressOutputStream.ComposeScreenDisallowUpdateRevokedKeyFlowTest: the "after lookup" check read the recipient from before the lookup. It now verifies the key stored after the lookup.grgitplugin with Gradleproviders.execfor the commit id and branch name.checkCorrectBranchnow checks the branch at execution time, so./gradlew tasks --allno longer fails on non-master branches.uiTestsno longer usesinitWith(debug). The shared settings live in aconfigureDebuggable()helper, which removes the AGPRES_VALUE_REPLACEDwarnings. GeneratedBuildConfigand resValues are unchanged.Configuration.setVisiblecalls and fixes the 2.3.13 concurrency regression (KSP 2.3.13 regression: library symbols disappear during concurrent in-process executions google/ksp#3286).Remaining warnings, left as is:
Parcelableargs. It suppresses them asCAST_NEVER_SUCCEEDS, but K2 reports them asUNSAFE_CAST_RELYING_ON_NULL. These are generated files, and suppressing the diagnostic globally would also hide real cases in our code. A comment inbuild.gradle.ktsdocuments this.BaseTestis intentional.allowBackuptools:replaceis kept on purpose, to guard against libraries enabling backup. The ACRAauthoritiesmerger warning comes from theacra-coremanifest.Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):