Repository navigation
#6337 Fix 25 encrypted attachments limitation - #6338
Merged
sosnovsky merged 1 commit intoNov 18, 2026
Merged
Conversation
Collaborator
Author
|
Hi @sosnovsky - This one is ready for a review. Thank you! |
sosnovsky
deleted the
issue-6337-fix-25-encrypted-attachments-limit-live-test
branch
November 18, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the hard-coded 25-item attachment render cap in the Gmail content script with the existing
Attachment.MAX_COUNT_PER_MESSAGEconstant (100). The cap was added by the DoS hardening in #6335 and truncated messages with 36 encrypted attachments to 25, even thoughGmailParser.findAttachmentsalready bounds attachments at 100. Reusing that constant keeps the DoS bound and restores full rendering.Closes #6337
Tests (delete all except exactly one):
mail.google.com - attachments rendered correctly(test/source/tests/gmail.ts), which asserts 36 rendered attachment frames. It needs live Gmail credentials, so it cannot run in unit CI. Verified locally withnpm run build,npx eslint, andnpm run test_local_unit_consumer.To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):