Repository navigation
Conversation
Allowlisted negative margins let untrusted message content escape its container and repaint trust UI. Both CSS sanitizers now remove margin declarations with negative lengths, with regression tests for shorthand, calc(), !important and logical-property variants.
Strip var()/attr()/env() margins and positioning offsets, and stop stripping valid positive calc() margins. Extends regression tests with the bypass variants found in review.
Collaborator
Author
|
Hi @sosnovsky - This one is ready for a review. Thank you! |
sosnovsky
reviewed
Nov 19, 2026
Comment on lines
+149
to
+150
| private static readonly NEGATIVE_CSS_LENGTH = /(?:^|\s|\()-(?:\d|\.)/; | ||
| private static readonly CSS_FUNCTION_VALUE = /\b(?:var|attr|env)\(/i; |
Collaborator
There was a problem hiding this comment.
these regexes allow calc expression, which can produce negative margins. for example, margin-top: calc(1% - 200px); will probably pass our check while giving negative margin. we should handle such cases too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes negative margins in both CSS sanitizers so untrusted message content cannot be displaced over trust UI.
close #6339
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):