Repository navigation
fix(minecraft-java): make Enforce whitelist turn the whitelist on - #67
Merged
Merged
Conversation
The WHITELIST_ENABLED field reached the itzg image as an env var of the same name, which the image never reads, so white-list stayed false and anyone could join. Export it as ENABLE_WHITELIST through the new configSchema envName (the image then sets white-list and enforce-whitelist). The config key stays the same, so saved server values keep working. Bump the bundle to 2.11.1. Needs the operator envName support (GameplanePanel/Gameplane); older operators drop the field and behave as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Enforce whitelist" (
WHITELIST_ENABLED) reached the itzg image as an env var with that same name, and the image never reads it. Because of that,white-liststayedfalseand anyone could join. The itzg image turns the whitelist on only forENABLE_WHITELIST,WHITELISTorWHITELIST_FILE, and withENABLE_WHITELIST=trueit also setsenforce-whitelist(start-setupServerProperties).envName: ENABLE_WHITELIST. The config key stays the same, so saved server values keep working.Depends on GameplanePanel/Gameplane#951 (operator
envNamesupport). Operators without it pruneenvName, so they keep today's behaviour and nothing breaks.gameplaneMinVersionis unchanged so that 0.4.0 installs can still load the bundle.Behaviour change: the field defaults to
false, and itzg writeswhite-list=falseon every start whenENABLE_WHITELIST=false. A whitelist switched on with the consolewhitelist oncommand is reset on restart unless the setting is on. The panel setting becomes the source of truth.🤖 Generated with Claude Code