Repository navigation
move process end and priority off the UI thread - #43
Merged
Merged
Conversation
Confirm End Process, End Process Tree, and Set Priority on the UI thread, then run them on one persistent SingleFlightWorker. Re-open each target with pid and creation time before TerminateProcess, the tree walk, or SetPriorityClass. A partial tree failure still uses the existing dialog. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End Process, End Process Tree, and Set Priority no longer call
TerminateProcess, walk the process tree, or callSetPriorityClasson the UI thread.ProcIdentityand the action go to one persistentSingleFlightWorker. Clicks do not spawn a thread, and a second confirmed action is queued behind the one already running.open_process_for_identityand requires both pid andcreation_time_100nsbefore it acts. An unknown or mismatched identity does not terminate a process, walk a tree, or change priority.PWM_PROC_WORKER_COMPLETEand is drained next to the process sampler. No new window message is added.Test plan
cargo check --all-targets --lockedcargo clippy --all-targets --locked -- -D warningscargo fmt --all -- --checkcargo test --all-targets --locked— not run here. This environment has nolink.exe, so the Windows MSVC test binary cannot be linked. Resource compilation also needsllvm-rc, which was not installed.