Repository navigation
fix: integrate reviewed PRs and repair restart and queue handling - #57
Merged
Merged
Conversation
EndTask can block in the target window's queue. Submit the selected window identities and the Ctrl force flag to a persistent single-flight worker, re-check the window before the call, and report only the first real failure on the existing completion path. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Append the already sampled counter strings to the networking list after IPv4. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Restart runs on the existing SCM worker. It stops the service, waits once within the published status hint, and starts only after the service is stopped. A failed stop or a failed start is reported and is not treated as success. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A second End Task click while one is running was merged with replace_pending, so the earlier selection never ran. Append each accepted command and run the queue in order, still re-checking the window before every EndTask. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Accepted startup toggles stay in order while the worker is busy. A later refresh no longer replaces that queue, and a toggle is not dropped when a refresh is already pending. Each command re-checks the stored entry identity immediately before the registry or startup-folder write. Co-authored-by: jameslincn <jameslincn@outlook.sg>
The panic hook flushes diagnostics and captures a backtrace before the collector can publish the failure. Poll for 30 seconds so that report and the reinitialized follow-up can arrive. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A zero physical memory limit is a missing measurement, not an empty machine. Leave the previous memory history point in place, label the meter with the existing Not Available text, and still record a later real 0% sample when the limit is known. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A missing or zero dedicated or shared limit is not measured 0% usage. Leave the previous history point, and still record a real zero once a non-zero limit is available. Co-authored-by: jameslincn <jameslincn@outlook.sg>
An accepted CPU sample cleared the stale flag before the usage delta was checked. When that delta is invalid and a previous percent exists, keep the percent, skip history, and report the page stale until a later valid sample, including a real 0%, replaces it. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A zero query interval now stores the current counters and stays NoRate, so bytes that moved while the clock was frozen are not counted on the next real interval. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Drop a later Users-page command when the same kind and session identities are already pending. A different session, kind, or logon time stays queued, and a coalesced refresh still does not erase those actions. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A second logoff or disconnect can become the first pending request without passing through merge. Remember commands still outstanding and do not submit the same kind and session identities again until that work finishes. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Exercise a full group of usize::BITS processors and an active count of usize::BITS + 1 on every pointer width. Masks shift only when the bit index is below usize::BITS, and a wider group returns OutOfRangeAffinityMask. Co-authored-by: jameslincn <jameslincn@outlook.sg>
The affinity dialog stays on the UI thread. After confirmation, the process identity and selected group masks are queued on the existing process-action worker. That worker re-opens the target with open_process_for_identity before SetProcessAffinityMask or SetProcessDefaultCpuSets. An unknown identity, a mask that does not fit the native KAFFINITY, or a group that cannot be expressed fails without writing a truncated mask. A later failure is not reported as success. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A missing or zero interval set valid before the elapsed check, and a failed detail counter returned before that check ran. Leave valid false, report InvalidElapsedTime, and do not publish processor percents from that interval. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A successful NtQuerySystemInformation result with a zero returned length is not a sample. Return an error and drop the default-zero counters instead of treating them as idle time. Co-authored-by: jameslincn <jameslincn@outlook.sg>
IsWow64Process2 reports IMAGE_FILE_MACHINE_UNKNOWN for every non-WOW64 process. Without a reported machine, return an error on every host instead of labeling that unknown process native. Co-authored-by: jameslincn <jameslincn@outlook.sg>
JamesLinYJ
marked this pull request as ready for review
November 9, 2026 01:44
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates #42, #44, #45, #46, #47, #48, #49, #50, #51, #52, #53, #54, #55, and #56 while preserving their commit ancestry.
Fixes five remaining review findings:
Validation of head 0788278:
Merge with a merge commit to retain the original PR heads and mark the integrated PRs merged.