Repository navigation
fix(terminal): report a closed transport once - #6
Merged
Merged
Conversation
Writes through a closed terminal view re-ran the close path, so every later keystroke emitted another onClosed event. Both platforms now return early once the transport is closed, and closeTransport emits only on the transition; a rebound source starts a new cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a shell closed, every keystroke sent another onClosed event on both platforms. A transport now reports onClosed exactly once; later writes are dropped until a new source is bound.
Verified on an Android emulator against the OpenSSH test container: before the fix, 12 typed characters after exit produced 12 extra events; after it, exit produces one event, typing produces none, and a reconnect produces one for the new shell. The macOS CI job verifies the iOS build.