Repository navigation
Conversation
Member
|
Thanks for this. The "Launch via Battle.net" button under PLAY already does exactly this route, so I'm keeping PLAY direct for now (same answer as #22). If I make it switchable later it'll be a Settings toggle, and I won't have Battle.net update a Lightforge-managed install, so the update-error change and the doc can't go in as they are. I will let this PR open for now, i will come back when i plan to do something like that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When WoW is started directly, its Remember Account checkbox still leaves users entering a password each launch. An opt-in
play_via_battle_net = truesetting now routes the main Play action through the existing Battle.net handoff, allowing the client's saved sign-in to carry into the game. Existing configurations keep direct launches.Only the Play action changes. The existing preflight, addon wait, readiness, game tracking and Stop paths are reused. Managed-game update errors give refresh/update guidance instead of inviting a repeated Play handoff. Documentation covers configuration, rollback and authentication limits.
Validation: 173 GUI tests, 45 Battle.net tests, 43 config tests and six deterministic behavior evaluations passed; release build succeeded. One independent code review passed after fixes to legacy-config coverage and update-error guidance. Installed locally and verified that the restarted process uses the built binary and the enabled setting. Live validation passed after one-time Battle.net installation reconciliation and enabling Seamless Battle.net Mode: WoW reached character selection and the user confirmed automatic login.