Skip to content

perf: ArrayBuffer.from without the isDirect() call #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
triniwiz wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −17
Open

perf: ArrayBuffer.from without the isDirect() call #2076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions test-app/runtime/src/main/cpp/ArrayBufferHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ using namespace v8;
using namespace tns;

ArrayBufferHelper::ArrayBufferHelper()
: m_objectManager(nullptr), m_ByteBufferClass(nullptr), m_isDirectMethodID(nullptr),
: m_objectManager(nullptr), m_ByteBufferClass(nullptr),
m_remainingMethodID(nullptr), m_getMethodID(nullptr) {
}

Expand All @@ -20,6 +20,7 @@ void ArrayBufferHelper::CreateConvertFunctions(Local<Context> context, const Loc
auto fromFunc = FunctionTemplate::New(isolate, CreateFromCallbackStatic, extData)->GetFunction(context).ToLocalChecked();
auto arrBufferCtorFunc = global->Get(context, ArgConverter::ConvertToV8String(isolate, "ArrayBuffer")).ToLocalChecked().As<Function>();
arrBufferCtorFunc->Set(context, ArgConverter::ConvertToV8String(isolate, "from"), fromFunc);
m_nativeObjectKey.Set(isolate, String::NewFromUtf8Literal(isolate, "nativeObject", NewStringType::kInternalized));
}

void ArrayBufferHelper::CreateFromCallbackStatic(const FunctionCallbackInfo<Value>& info) {
Expand Down Expand Up @@ -75,19 +76,11 @@ void ArrayBufferHelper::CreateFromCallbackImpl(const FunctionCallbackInfo<Value>
throw NativeScriptException("Wrong type of argument (ByteBuffer expected)");
}

if (m_isDirectMethodID == nullptr) {
m_isDirectMethodID = env.GetMethodID(m_ByteBufferClass, "isDirect", "()Z");
NS_CHECK(m_isDirectMethodID != nullptr);
}

auto ret = env.CallBooleanMethod(obj, m_isDirectMethodID);

auto isDirectBuffer = ret == JNI_TRUE;

Local<ArrayBuffer> arrayBuffer;

if (isDirectBuffer) {
auto data = env.GetDirectBufferAddress(obj);
auto data = env.GetDirectBufferAddress(obj);

if (data != nullptr) {
auto size = env.GetDirectBufferCapacity(obj);

std::unique_ptr<v8::BackingStore> store = ArrayBuffer::NewBackingStore(
Expand Down Expand Up @@ -115,11 +108,11 @@ void ArrayBufferHelper::CreateFromCallbackImpl(const FunctionCallbackInfo<Value>

auto byteArrayElements = env.GetByteArrayElements(byteArray, 0);

jbyte* data = new jbyte[bufferRemainingSize];
memcpy(data, byteArrayElements, bufferRemainingSize);
jbyte* copy = new jbyte[bufferRemainingSize];
memcpy(copy, byteArrayElements, bufferRemainingSize);

std::unique_ptr<v8::BackingStore> store = ArrayBuffer::NewBackingStore(
data,
copy,
bufferRemainingSize,
[](void *data, size_t length, void *deleter_data) {
delete[] ((jbyte*)data);
Expand All @@ -131,7 +124,7 @@ void ArrayBufferHelper::CreateFromCallbackImpl(const FunctionCallbackInfo<Value>
}

auto ctx = isolate->GetCurrentContext();
arrayBuffer->Set(ctx, ArgConverter::ConvertToV8String(isolate, "nativeObject"), argObj);
arrayBuffer->Set(ctx, m_nativeObjectKey.Get(isolate), argObj);

info.GetReturnValue().Set(arrayBuffer);
}
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/ArrayBufferHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace tns {
ObjectManager* m_objectManager;

jclass m_ByteBufferClass;
jmethodID m_isDirectMethodID;
v8::Eternal<v8::String> m_nativeObjectKey;
jmethodID m_remainingMethodID;
jmethodID m_getMethodID;
};
Expand Down
Loading