Repository navigation
refactor(dynamic-apps): contract-selected workspaces and verified writes - #537
Conversation
Rules are reviewed, versioned readings of contract shapes. They may read names and declared types but never invent an endpoint, method, parameter, payload field, permission, identity, or idempotency guarantee. No rule ships yet; each will arrive with fixtures from at least two apps.
The contract information dialog moves out of the app shell into its own file and is reachable again from the app header menu as App compatibility details. A write safety section lists paused and probationary routes with their typed reason and rule, explains an unreadable state, and offers Resume changes, which clears only that app's state on this device.
AGENTS.md section 4 now states the app-agnostic evidence tiers, risk classes, and admission matrix, keeping the note naming the remaining app-gated exceptions; section 7 records diagnostics, probation, quarantine, and full-echo rules. The descriptor, adapter, schema, compatibility, and roadmap documents describe what is present in source with deterministic tests and what remains, and the size baseline is lowered for shrunken files.
…ches - Drop a routes.php route and an attribute route that serve the same URL and verb from different controller methods; the server dispatches the attribute route, so the file route's signature would send the wrong body. - Never publish sub-administrator, delegated administrator, external-app, or password-confirmed methods as writes; administrator access inferred from a missing NoAdminRequired stays a fact for admission. - Keep uploaded-file methods as route evidence until a stored file can be verified. - Count supplementary package files only against their own budget. - Read method names only directly after `function`, so closures never supply a signature, and distrust repeated method names. - Read legacy annotations only in the indented line form the server reads, and accept Route(type:) only from the framework Route class.
A cell-map row's representation is its stored cells. A declared input outside the cell map that is optional, accepts null, and is not returned by the row read, such as a view that scopes the request, is not stored row data, so it is neither echoed nor sent. Unreturned required or non-nullable inputs still keep the row read-only. This keeps table row editing available for contracts shaped like Tables 2.4.0.
Brings in signed-package contract facts. A write whose package access rule limits it to administrators is now classified as administration (R9) and refused; missing facts count as unknown.
Non-GET dynamic API requests, multipart uploads, and exactly-once sends now use a client with connection-failure retries disabled on desktop and Android, so a body that was already written is never sent a second time.
Only client OCS codes (4xx, v1 101-199, 997, 998) are rejections. A server error, an unknown code, or contradictory metadata may hide an applied write, so the exactly-once send keeps its attempt record.
Without draft storage the composer keeps drafts in memory but no longer sends, because an attempt recorded only in memory would read as unsent after process death.
Resume changes now opens a confirmation naming each paused route and why it was paused before clearing the app's write safety state.
A full echo needs exact stored JSON values, which a form body cannot carry, so such records are read-only instead of failing at submit.
- The baseline restore offered after drift is the one write a quarantined route accepts, only as the exact offered request and only once. It compares a pre-read with the drifted state and reads every baseline field back; normal edits stay refused. - Write safety keys always form: an app ID, version, or route outside the key alphabet is keyed by a digest of its exact string, so a quarantine is never dropped. - Read-back verification compares only edited fields, so a parent input of another JSON type cannot turn a reverted edit into an adjustment. - A share is sent only when a fresh, bounded read of the target returns its declared permission field as true.
Describe the R1 admission gap, OCS outcome classes, non-retrying write transport, digest-keyed write safety state, baseline restore, share permission reads, and the resume confirmation. Note that Deck board writes bypass generic admission, that the Rust risk classification is a reference subset, and update the replacement edit evidence row.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daead5342e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fefcdbda2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e and readable edited cells
…ctor/dynamic-apps
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adc7c02744
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ctor/dynamic-apps
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dad37c2fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ends inside a UTC day
…ctor/dynamic-apps
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75f173b24a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ctor/dynamic-apps
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa5fe5a754
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ctor/dynamic-apps
Outcome
Moves dynamic apps from app-specific handling to behavior selected from each installed app's verified contract, and adds a verified write path for the cases a contract fully describes.
AGENTS.md, the adapter and descriptor contracts, and the changelog describe evidence tiers, risk classes and the remaining gaps.Advances #48, #42, #52, #54, #493.
Includes the app experience round from #536
This branch is built on #536 and now targets
maindirectly, so it carries that work too:The Mail composer and the reviewed Tables, Cospend and Forms writes that #536 introduced are replaced here by the contract-driven versions, so neither earlier form reaches
main.Also advances #130, #39, #118, #12, #188, #58, #57.
Verification
bash tools/check-repository.shpasseschanges/unreleased/fragment records the changeRun on Windows on commit
0ba421c5; this head has the identical tree (the only addition is a merge of the base branch that changes no files)::ui:desktopTest: 4,889 tests, 70 skipped, 0 failures:androidApp:testDebugUnitTest: 1,188 tests, 0 failuresbash tools/check-kotlin-architecture.shandbash tools/check-repository.sh: passed. The Debian package build check was skipped becausedpkg-debis not available on Windows.Compatibility and risk
Visual changes
Not applicable beyond the existing workspaces now being selected from contracts and paused changes appearing in app compatibility details. Screenshots are not attached.