Skip to content

fix(android-sync): visible scan failures, offline pairs, restoration and settings editing - #538

Merged
veryCrunchy merged 5 commits into
mainfrom
fix/mobile-file-sync-reliability
Nov 16, 2026
Merged

veryCrunchy merged 5 commits into
mainfrom
fix/mobile-file-sync-reliability

Conversation

@veryCrunchy

Copy link
Copy Markdown
Member

Outcome

Hardens Android folder sync after an audit on an emulator found three bug classes and one known gap.

  • Scan failures stay visible: a failed scan, including one before the first successful scan, is saved with its kind and a recovery instruction. A lost folder grant or a server error no longer shows as "Not checked yet". A later successful scan clears it; cancellation is not recorded as a failure.
  • Saved pairs while offline: pairs saved on the device can be opened while the account's details cannot be loaded. Changes stay off until the account is identified.
  • Restoration: the open pair and its Settings tab survive activity recreation and process death. A settings notice no longer resets the selection.
  • Editing settings: direction, conflict handling, deletion, connection, power and the device label can be changed, with explicit Apply and discard. A stale review, a running sync or an unfinished upload refuses the change. Settings save atomically and the background schedule is reconciled.
  • Smaller fixes: reading status no longer reschedules jobs or marks live work as interrupted, phone lists virtualize up to the supported 64 pairs, and choice controls expose radio semantics.
  • Documentation: the adapter and platform notes, the Android folder sync guide and a changelog fragment describe the behavior without claiming a published release.

Advances #110, #111, #126, #148.

Verification

  • Every check relevant to the changed scope passes, or each unrun check is listed below with a reason
  • bash tools/check-repository.sh passes
  • A new changes/unreleased/ fragment records the change
  • No credentials, private server data, machine-local paths, or generated output are included

On this head, on Windows with JDK 21:

  • :ui:desktopTest for the file sync, sheet and offline center tests: passed
  • :androidApp:testDebugUnitTest for the file sync and storage access tests: passed
  • bash tools/check-kotlin-architecture.sh and bash tools/check-repository.sh: passed. The Debian package build check was skipped because dpkg-deb is not available on Windows.
  • Website content generation for the changed guide: passed

On the commit before main was merged in (the merge touched two lines of shared code and the size baseline):

  • 284 shared and 239 Android file sync unit tests: 0 failures
  • 14 instrumented tests on an API 36 phone emulator: storage and restart recovery, expired folder grants, HTTP 503, failed-scan clearing, offline cold start, settings review and save, WorkManager constraints, recreation, dirty Back, landscape controls, the native folder picker
  • The UI flow on tablet and compact-phone metrics, and a process-death restoration check

Not rerun on this head: the instrumented emulator tests. The full desktop and Android suites run in CI.

Compatibility and risk

Visual changes

The pair Settings tab gains editing controls and an Apply/discard step. Screenshots are not attached.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #538 / NC Native November 15, 2026 17:23 Destroyed
@obiente-cloud

obiente-cloud Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Obiente preview

NC Native · 36ffdfb9a14f · Removed

View preview status

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T17:27:05.902448Z 29766f4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #538 / NC Native November 15, 2026 17:30 Destroyed
@veryCrunchy
veryCrunchy merged commit c109a14 into main Nov 16, 2026
6 checks passed
@veryCrunchy
veryCrunchy deleted the fix/mobile-file-sync-reliability branch November 16, 2026 04:38

This branch was successfully deployed

No deployments
Obiente Preview / PR #538 / NC Native — 36ffdfb9 Deployed Nov 15, 2026 by obiente-cloud[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant