Repository navigation
fix(android-sync): visible scan failures, offline pairs, restoration and settings editing - #538
Merged
Merged
Conversation
…oncile the schedule
…reliability # Conflicts: # tools/kotlin-file-size-baseline.txt # ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudPlatform.kt
obiente-cloud
Bot
temporarily deployed
to
Obiente Preview / PR #538 / NC Native
November 15, 2026 17:23
Destroyed
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
obiente-cloud
Bot
temporarily deployed
to
Obiente Preview / PR #538 / NC Native
November 15, 2026 17:30
Destroyed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Hardens Android folder sync after an audit on an emulator found three bug classes and one known gap.
Advances #110, #111, #126, #148.
Verification
bash tools/check-repository.shpasseschanges/unreleased/fragment records the changeOn this head, on Windows with JDK 21:
:ui:desktopTestfor the file sync, sheet and offline center tests: passed:androidApp:testDebugUnitTestfor the file sync and storage access tests: passedbash tools/check-kotlin-architecture.shandbash tools/check-repository.sh: passed. The Debian package build check was skipped becausedpkg-debis not available on Windows.On the commit before
mainwas merged in (the merge touched two lines of shared code and the size baseline):Not rerun on this head: the instrumented emulator tests. The full desktop and Android suites run in CI.
Compatibility and risk
Visual changes
The pair Settings tab gains editing controls and an Apply/discard step. Screenshots are not attached.