Repository navigation
Conversation
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently loch only samples water, and the osmotic (μpT) ensemble isn't valid for water as the solvent of a dilute system, such as a solvated protein, which is loch's main use. Water's chemical potential is then almost that of pure water, so the number of waters is barely fixed, and any mismatch between the excess chemical potential and the water model's chemical potential drives the total water count steadily one way. Sampling only within the GCMC sphere doesn't avoid this, since water diffuses between the sphere and the bulk.
The osmotic ensemble is valid for water only when its chemical potential depends strongly on how much is present, e.g. adsorption into a porous solid or water in a non-aqueous solvent. These aren't loch's target use.
Changes:
pressureargument and the per-move box and Adams value updates. A barostat is rejected again, as before osmotic support was added._compute_adams_values()is called once at construction, using the box fromset_box(). The long-range correction reuses that box volume.set_box()no longer accepts an OpenMMState.tests/test_osmotic.py, and restore the README note that GCMC must be performed at constant volume, removing the μpT documentation (including Fix issue #59 #60).