Repository navigation
Phone app: the dev client on Play starts and loads from Metro (deploy#22) - #325
Merged
Merged
Conversation
…ies (deploy#22) The release build with expo.devlauncher.configureInRelease takes expo-dev-launcher's debug code and resources but not its debug manifest, so OpenClapper Dev from Google Play crashed on start (ActivityNotFoundException: DevLauncherActivity). withDevClientInRelease now adds the launcher's three activities, its meta-data, permission and query to the app's manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
React Native's dev support follows ReactBuildConfig.DEBUG unless MainApplication passes useDevSupport, so the release-built dev client got the ReleaseDevSupportManager and the launcher could not load a bundle from Metro. withDevClientInRelease now passes useDevSupport = true and allows cleartext HTTP (Metro on the LAN), as the debug build does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… JPromise error open (deploy#22) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Second commit: Checked on the owner's phone with version code 3611038 from this branch (internal track): the launcher, the |
bubulux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #324. OpenClapper Dev from Google Play crashed on start:
ActivityNotFoundException: Unable to find explicit activity class {org.openclapper.dev/expo.modules.devlauncher.launcher.DevLauncherActivity}expo-dev-launcher's
configureInReleaseadds its debug Java code and resources to the release build, but notsrc/debug/AndroidManifest.xml(itsbuild.gradle, SDK 57).withDevClientInReleasenow declares the three activities (DevLauncherActivity,AuthActivitywith theexpo-dev-launcherscheme,DevLauncherErrorActivity), the ML Kit meta-data,CHANGE_WIFI_MULTICAST_STATEand thehost.exp.exponentquery in the app's manifest, for thedevelopmentvariant only. The known-issues entry is updated.Checked:
make checkis green.APP_VARIANT=development expo prebuild: the generated manifest has all the entries, andgradle.propertieshas both switches.Not checked yet: the phone. Next is a Play build from this branch (deploy's Development · Build phone app with
ref).🤖 Generated with Claude Code