Repository navigation
Fix for sigmastar read (missing every 25th byte in the backup) - #97
Conversation
PR Summary by QodoSend SigmaStar ISP read command once per read
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. The read fix is verified only against a self-written simulator
|
|
Thank you @igorssv, this is a real bug, and the fix is right: a repeated I reproduced it in our ISP simulator ( We will also check it on a SigmaStar board in our lab. A question: have you tried OpenIPC/snander-mstar on the same board (CH341A + SSC30KQ)? It would be interesting to compare how it reads and writes there. |
|
/review |
|
Merged, thank you @igorssv. It is in microsnander 1.47.3: the |
|
I checked snander-mstar and it is working correctly (I also did other tests for reading and verification data): I confirmed that current version microsnander 1.47.5 is work working correctly too for my CH341A + SSC30KQ: |
I found that microsnander can not verify wrote data. Every time the first difference was at 0x0000000000000018.
I used ch341a programmer and cam board with SoC ssc30kq with nor flash.
After investigation I found that each 25th byte is missing in the output file when I read data from flash using microsnander. Missing bytes at 0x18, 0x31, 0x4A, ...
After review the source code I found that miss byte after additional SPI Read (0x11) command before read next 24 bytes. I updated the code to execute this command once at the read start. Now it is working for me for ch341a+ssc30kq with nor flash, but I have not another hardware for more tests.