Skip to content

build(docker): upgrade base images to trixie, upgrade harfbuzz - #77

Merged
kad-korpem merged 5 commits into
masterfrom
lighttpd-upgrade
Nov 16, 2026
Merged

kad-korpem merged 5 commits into
masterfrom
lighttpd-upgrade

Conversation

@kad-korpem

Copy link
Copy Markdown
Collaborator

Description

  • Upgrade base images to Debian trixie, upgrade harfbuzz version as required.
  • Add text rendering smoke test (related to harfbuzz upgrade).

Type of change

  • Minor change (typo, formatting, version bump)
  • Improvement of existing feature

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The regression-test step exits under bash -e when PNG bytes differ, preventing the perceptual fallback and cleanup from running even for visually identical images.

1 open issue
What changed in this PR

Upgrades the MapServer container stack to Debian trixie and adds a text-rendering smoke test to check compatibility with the newer HarfBuzz library.

Changes:

  • Updates builder and service base images and the SpatiaLite runtime package.
  • Upgrades HarfBuzz to 10.2.0 and switches its build to Meson.
  • Adds multilingual label fixtures and a WMS image-comparison smoke test.
File Description
testdata/​labels/​labels.map Defines TrueType label rendering for the smoke test.
testdata/​labels/​labels.geojson Provides multilingual text and shaping samples.
testdata/​labels/​labels.conf Registers the test map with MapServer.
testdata/​labels/​fonts.txt Maps the test font alias to DejaVu Sans.
testdata/​labels/​DejaVu-LICENSE.txt Supplies license notices for the bundled font.
Dockerfile Updates base images, dependencies, and the HarfBuzz build.
.github/​workflows/​regression-test.yml Adds the WMS label-rendering smoke test.

Review effort: Balanced

Comment thread .github/workflows/regression-test.yml Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Debian and Lighttpd upgrades leave container builds, native-library linkage, Lua/FastCGI startup, and regression compatibility unverified for both default and NL variants.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Comment thread .github/workflows/regression-test.yml Resolved

@hleushuis hleushuis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zie opmerking t.a.v. gebruik backtick syntax in command substitution.

@kad-korpem
kad-korpem merged commit 076e607 into master Nov 16, 2026
1 check passed
@kad-korpem
kad-korpem deleted the lighttpd-upgrade branch November 16, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants