Repository navigation
build(docker): upgrade base images to trixie, upgrade harfbuzz - #77
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The regression-test step exits under bash -e when PNG bytes differ, preventing the perceptual fallback and cleanup from running even for visually identical images.
1 open issue
What changed in this PR
Upgrades the MapServer container stack to Debian trixie and adds a text-rendering smoke test to check compatibility with the newer HarfBuzz library.
Changes:
- Updates builder and service base images and the SpatiaLite runtime package.
- Upgrades HarfBuzz to 10.2.0 and switches its build to Meson.
- Adds multilingual label fixtures and a WMS image-comparison smoke test.
| File | Description |
|---|---|
testdata/labels/labels.map |
Defines TrueType label rendering for the smoke test. |
testdata/labels/labels.geojson |
Provides multilingual text and shaping samples. |
testdata/labels/labels.conf |
Registers the test map with MapServer. |
testdata/labels/fonts.txt |
Maps the test font alias to DejaVu Sans. |
testdata/labels/DejaVu-LICENSE.txt |
Supplies license notices for the bundled font. |
Dockerfile |
Updates base images, dependencies, and the HarfBuzz build. |
.github/workflows/regression-test.yml |
Adds the WMS label-rendering smoke test. |
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
The Debian and Lighttpd upgrades leave container builds, native-library linkage, Lua/FastCGI startup, and regression compatibility unverified for both default and NL variants.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
hleushuis
reviewed
Nov 16, 2026
hleushuis
reviewed
Nov 16, 2026
hleushuis
left a comment
Contributor
There was a problem hiding this comment.
Zie opmerking t.a.v. gebruik backtick syntax in command substitution.
hleushuis
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
trixie, upgradeharfbuzzversion as required.harfbuzzupgrade).Type of change
Checklist: