Repository navigation
feat: run settings via StepCtx.settings (RFC 009) - #1
Merged
Merged
Conversation
… > library with - every step knob (node-version, install-dir, node-path, cwd, timeout, env) resolvable from run settings; explicit step with wins; env maps merge extension > variables > library with over the default PATH - claims the 'nodejs' config extension key via configSchema (unknown keys fail the run); invalid settings blocks are hard errors - library-level with defaults validated at init - tests: 26 passing (precedence, env merge, invalid blocks, init) - CI: pinned actions, SDK pinned to 522cfdd, perfscale v0.30.0 engine e2e
The SDK package resolves main/types from dist/; npm ci alone left no dist, so tsc failed with TS2307/implicit-any. npm run build added after npm ci; verified locally against a dist-less SDK checkout.
…d node The host import hard-errors on spawn-ENOENT, so the cold-cache 'node --version' probe aborted install before any download. Probe with test -x first; also build the SDK in CI (dist + d.ts) so tsc resolves @perfscale/library-sdk.
…e-path) Relative install-dir made the installed node-path relative, which exec refuses. Examples use the absolute default; README notes the constraint and the test -x cache probe.
vitalics
marked this pull request as ready for review
November 1, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with:>extensions[nodejs]>variables[nodejs]> librarywith:> built-in defaults; env maps merge in that ordernodejsconfig extension key viaconfigSchema; invalid settings are hard errors; librarywith:validated at init