Repository navigation
import-ldif: names are unique only in their container (#133) - #135
Merged
Merged
Conversation
An LDIF of a whole vault (several driver sets, a Library outside them) stopped with 'duplicate artifact path: library/...' and took every driver set's drivers. The reader now takes the chosen driver set's own drivers, policies, entitlements and jobs by DN; from other Libraries, every object of a Library outside every driver set and what the set links from another set's Library, as read-only references (library.dn); two of one name keep the set's own, with a NOTE. --driver-set DN names the driver set when the LDIF holds several. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133.
import-ldifplaced objects by the RDNs between them and the driver set, and assumed everything in the LDIF belonged to the one driver set. Given an LDIF of more than the driver-set subtree (several driver sets, a Library outside them such ascn=Library,o=services), it:library/, so two of one name stopped the import withduplicate artifact path: library/<name>;ADdrivers, say), and attached other sets' entitlements and jobs to a driver of the same name.Now:
--driver-set DN; without it the import stops and lists them.import-projecttreats them (Model a driver set that uses Libraries in more than one container #111). Every object of a Library outside every driver set, and what the set links from another set's Library, go intolibrary/as read-only references withlibrary.dn. Another set's unlinked Library objects stay out. Links to them resolve tolibrary/.NOTE:line (DuplicateArtifacts.drop, asimport-projectalready does).Checked: a two-driver-set LDIF built from the synthetic fixture plus a shared
cn=Library,o=servicesfails on master with klasen's error. On this branch it imports with--driver-set, andcheckandvalidateare clean (onelibrary-otherinfo). The plain one-set fixture imports byte for byte as on master. 1064 tests pass.import-livereads only the driver-set subtree, so it can't meet the outside Library. It gets the same duplicate handling for two objects of one name inside the subtree.🤖 Generated with Claude Code