Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying World Rally Fever (1996) (Split, Team17 Software)
Original PR: #598
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
Yes,
ROOTS.DIRis needed for its file paths. Sound config is changed with an in-game menu.Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
No, I moved it to root.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
GOG doesn't match due to its different CD image. I am unable to add a variant.
Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, I added it to
ROOTS.DIR.Can DoDAT build the game from the install media?
Yes.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
No, I added them.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
A CD needs to be inserted to avoid an error, but the data track is not technically needed with all files extracted and the path in
ROOTS.DIRedited toC:\. However, there are still audio tracks anyway, and no bloat like game demos on the disc, so this only saves 4 MB over the normal setup.For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Can the game benefit from using CHDtoOGG?
Yes, it already did. I changed to the -n option, and also used a different release which may be more accessible: World Rally Fever (Europe) (En,Fr) (Rerelease)
Also moved all of the files into the CD folder.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Not applicable.
Is the game running at the correct speed? Is CPU year specified?
No CPU setting was specified. I used
cpu_max_year: 1998.Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
I removed
run_pathbecause it somehow causes a bug with the game - first time I've seen this. When it's used to auto-start, it shows the first 2 logos, but skips the 3rd logo and the intro, and then the demos on the title screen end too quickly. This does not happen when runningRALLY.EXEfrom DOSBox Pure's file list.I confirmed that other factors were not causing this:
ROOTS.DIRmatching either way)C:\RALLY(withROOTS.DIRmatching either way)run_pathwas thereRunning a BAT file with "rally" also had no effect. It seems to be determined by
run_path. I removed it for now since it's a shame to lose the intro, but this is very unusual since auto-start is always used.Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Yes.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
There is no cursor.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Comment
Summary of changes:
ROOTS.DIRand added embedded datacpu_max_year: 1998