Repository navigation
Conversation
…tead of having EXE files that were modified and compressed with UPX 2 or 3 (which first came out in 2006), use original copy protected EXE file in DOSZ, add IPS patch to skip copy protection to DOSC, use dates from ARJ file, increase CPU speed limit for smoother animation (game was released in 1995 when PCs were already quite powerful)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Dokkaebiga Ganda (1995) (Senori Box)
Original PR: #714
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
The config doesn't need to be in the DOSZ. It is created by
PLAY.BAT.Have any official patches been applied, if necessary?
Didn't find any sign of patches for this game.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
It isn't on GOG/Steam.
Can the game benefit from using embedded data or embedded patches in the datfile?
No.
Can DoDAT build the game from the install media?
Not applicable.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
Yes.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
Not applicable.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Can the game benefit from using CHDtoOGG?
Not applicable.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
It appears that copy protection has already been removed.
Is the game running at the correct speed? Is CPU year specified?
Yes,
cpu_cycles: 4300was set.Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
There is no cursor.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Comment
Summary of changes:
The DOSC was accidentally left out of the original PR, but I added it here with no changes.