Skip to content

Verify Gorillas - #848

Open
tomojira wants to merge 2 commits into
PureDOS:mainfrom
tomojira:gorillas
Open

tomojira wants to merge 2 commits into
PureDOS:mainfrom
tomojira:gorillas

Conversation

@tomojira

Copy link
Copy Markdown
Contributor

Verifying QBasic Gorillas (1990) (Microsoft)

Original PR: #786

Checklist

Have adequate installation instructions been provided to match any config files in the DOSZ?
There are no config files.

Have any official patches been applied, if necessary?
There are no patches. Deluxe Edition is already the latest version, v2.2.

Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.

Is the entry in the right variant file (i.e. Freeware)?
Yes, except maybe Deluxe Edition if it counts more as its own game rather than a variant. But I left it as a Misc variant.

Have digital versions (Steam, GOG) been checked for matching?
It isn't on GOG/Steam.

Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, it's already used for the BAT file.

Can DoDAT build the game from the install media?
Not applicable.

If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.

Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.

Do the file timestamps match the installation media?
Yes.

Does the DOSZ run standalone?
Yes.

For CD games, can the game be set up to run without a CD mounted?
Not applicable.

For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.

Can the game benefit from using CHDtoOGG?
Not applicable.

Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.

Does the DOSC contain problematic data (i.e. copyright issue)?
No.

Does the DOSC have copy protection removed, if possible?
Not applicable.

Is the game running at the correct speed? Is CPU year specified?
cpu_year: 1989 was set, but I changed it to 1985 so the moving border on the title screen looks a little better. The exception is Deluxe Edition, where it already looked fine, so I left that at 1989.

Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes, but I changed it to WAITMODECHANGE.

Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.

Does the game have General MIDI support?
No.

Is the game set up to run with the best quality graphics options by default?
Not applicable.

For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.

Does the game have a mouse cursor that benefits from enabling input_directmouse?
There is no cursor.

Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.

Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.

Comment

Summary of changes:

  • Changed to cpu_year: 1985 (except Deluxe Edition)
  • Changed to WAITMODECHANGE
  • Edited comments and links

I wasn't sure about the naming of the variants, if the year and developer should match the main version, leaving only the variant tag to distinguish them. But I left them as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant