Repository navigation
CIP-0001 Phase 2: MPI deprecation and typemap removal - #38
Merged
Merged
Conversation
Refuse silently wrong mpi_comm without back-constraints, warn on use, let mpi4py infer buffer types, and add an optional 2-rank CI parity job.
Serial vs partitioned MPI LLs only match when they share parameters; the previous check compared independent random initialisations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy_to_MPI_typemap; mpi4py infers datatypes from NumPy buffers (R8).ValueErrorformpi_commwithback_constraint=False(silently wrong before) (R9).FutureWarningwhenmpi_commis set (R10).mpiexec -n 2parity vs serial for a back-constrained model (R11).Test plan
testjob greenmpijob green (OpenMPI + mpi4py)