Skip to content

CIP-0002: Implement MRD revival (Phases A–C) - #43

Merged
lawrennd merged 1 commit into
mainfrom
cip0002-mrd-revival
Nov 13, 2026
Merged

lawrennd merged 1 commit into
mainfrom
cip0002-mrd-revival

Conversation

@lawrennd

Copy link
Copy Markdown
Member

Summary

  • Phase A: Fix ObservedMRDLayer variational-bound shape (scalar vs (1,)), init-string equality, construction/optimize unit tests.
  • Phase B: Include mrd.py in coverage; document multi-view API in README; add examples/example_mrd.py.
  • Phase C: Wire NumPy MLP encoder into MRD views; skip duplicate EncoderLayer on the MRD leaf; re-entrancy guard; back-constraint tests.
  • Mark CIP-0002 Accepted / In Progress. Phase D (MPI strip / CIP-0001 R20) remains follow-up.

Test plan

  • python -m unittest deepgp.testing.test_mrd -v
  • Full unittest discover (53 tests OK)
  • CI on this PR

Fix bound dtype aggregation, init-string dispatch, and NumPy encoder wiring
for back-constrained views; add tests, coverage, docs, and example_mrd.
@lawrennd
lawrennd merged commit ba427b2 into main Nov 13, 2026
4 checks passed
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.96%. Comparing base (59464ca) to head (8b12a98).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   72.24%   74.96%   +2.71%     
==========================================
  Files          16       17       +1     
  Lines        1070     1254     +184     
  Branches      156      185      +29     
==========================================
+ Hits          773      940     +167     
- Misses        240      255      +15     
- Partials       57       59       +2     
Flag Coverage Δ
unittests 74.96% <100.00%> (+2.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant