Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439.
updateMaxPacketLengthused modulo instead of division for the packet count and counted one message too many, so shrinking the max over-created packets, advancedmessagePackedpast the messages that exist, and permanently bricked the capacitor (every lateraddPackedMessagereverts on a uint64 underflow, panic0x11, with no setter to recover).The fix computes the true pending count (
nextMessageCount - messagePacked - 1, sincenextMessageCountis 1-indexed) and divides by the new max. Both changes are required.Tests: five new regression tests against the fixed contract (0/1/4/6 pending, shrink-after-some-packed), all pass; the three reproduction tests fail against the fixed contract as expected, confirming the brick is gone; the existing 10
HashChainCapacitor.t.soltests pass with no regression.This does not touch the separate stale-state validation bug (#436 / PR #438).