Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Add C's astRemoveRegions as a package-private removeRegions() on Mapping (mapping.c: the Mapping itself), overridden in Region (a copy of the current Frame), Frame (narrowed return type), CmpMap, TranMap, RateMap, SwitchMap, CmpFrame and FrameSet, each following its C file's RemoveRegions, with unchanged components shared as C's clones are. Convert the remove_regions oracle (9 of 11 cases; the NormMap cases are skipped) and add remove_regions_extra_probe.c for the nesting it does not cover; translate remove_regions_from_frameset, remove_regions_unit_passthrough and check_remove_regions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Port jniast's SelectorMap from selectormap.c, with Rust selectormap.rs as the guide: copies of the Regions, C's Transform (each Region negated and its Closed reversed in place, both put back and so left set), Equal (Invert not compared), MapMerge (a simplified Region found by identity; the neighbour inverted, compared with Equal and inverted back), Copy, Dump (later Regions written without their Frame) and the loader (later Regions given the first Region's FrameSet), with C's constructor messages. selectormap_probe.c pins the indices for overlapping, negated, unbounded and open Regions, the dump after a transformation, simplification, the pairs in series (two equal 1-D SelectorMaps both forward merge into a UnitMap in C), the loads and the constructor's errors. Translate test_selectormap.rs, the SelectorMap tests of test_switchmap.rs (testswitchmap.c section 3 included), the SelectorMap cases of the equal, rate and object ID oracles, a_selectormap_needs_regions_in_one_frame, jniast's AstTest.testSwitchMap and the two SelectorMap cases of remove_regions_extra_probe.c. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Remove from the deferred lists the entries whose only missing class was SelectorMap: 10 each of full-dumps, read-warnings and serialisation, 8 each of simplify and simplify-cases, and the 25 Rust tests now translated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
region.c's Dump writes Negate, Fill, MeshSz, Closed and Adapt from the Region class's own fields where they are set, through its static Test and Get functions, and asks the class's accessor only for an unset value. Region.dump now does the same, so a PointList with Closed set writes the value set rather than the opposite of Negated, and a class that reads these attributes from elsewhere writes its own settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Port stc.c and stcresourceprofile.c with Rust's stc.rs as the guide: an abstract Stc that encapsulates a copy of a Region (or, given an Stc, its encapsulated Region mapped into the Frame it represents), forwards its geometry, Negated, Closed, MeshSize and FillFactor to it, holds copies of its AstroCoords KeyMaps mapped into its Frame, and dumps, loads, copies, compares and simplifies as C's does; jniast's plain AstroCoords class and its package-private converters; and StcResourceProfile. As C's Transform and GetBounded do, an Stc sets its encapsulated Region's Negated to the value it has around the call, leaving it set. A dump without the Region or a Coord<n> item, where C stores a null and crashes later, and a "Begin Stc" of the abstract class, which C reads, are AST__LDERR. The region_stc oracle runs its StcResourceProfile cases; the fitted Error Ellipse's axis ends are left out of the comparison and its half-lengths compared instead. stc_probe.c pins the rest against C. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Remove from the deferred lists the entries whose only missing class was StcResourceProfile: cap_timemap_02 from full-dumps, read-warnings, serialisation and simplify (2 each) and simplify-cases (1); and the three Rust tests of test_region_stc_oracle.rs now translated in full. stc_matches_c, whose StcResourceProfile cases now run, stays listed for the other Stc classes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
StcSearchLocation, StcCatalogEntryLocation and StcObsDataLocation, with StcObsDataLocation's observatory position (written as ObsLoc only when present, copied in a copy, shared by the package-private setObs, not compared). Region.cast copies a Region into the class of any Region it is an instance of. RegionStcOracleTest runs every oracle case, the Full = 1 dumps and C's dumps read back; stc_probe gains checkStcObsDump, the observatory position and Stcs of different classes; jniast's StcTest.testConstructors is translated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Region.cast crashes in C only until a Region description is read; the probe's last case reads one and pins the CmpFrame conversion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
astConvert through CmpFrames gives region.c Cast the target's picked axes, a Frame, so Cast casts the Region's current Frame; only the protected astCast reaches its astCastCopy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
The observatory position takes part in equals, which compares the descriptions, but not in C's astEqual. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Give the C defects as counts only, correct the Cast call path in the Gaps section and the Task 4 ruling, and say what Region.cast accepts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Pin with C the RemoveRegions branches no case reached: a SwitchMap's inverse selector holding a Region and being one, and a SwitchMap route and a RateMap Mapping that is a FrameSet holding a Region, which C turns into a UnitMap since astIsAFrame is true of a FrameSet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Compare the names of the remove_regions_extra_probe cases with those RemoveRegionsTest lists, in order, and check each case it makes is listed, instead of counting the cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Name in removeRegionsFromFrameSet's Javadoc the C-valued cases that remove a Region a FrameSet holds, since its own FrameSet holds none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Share the neighbour step of SelectorMap's and SwitchMap's mapMerge, the same code in selectormap.c and switchmap.c, as Mapping.cancelWithNeighbour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Say in SelectorMap's Javadoc that its description shows Closed for every Region after a transformation, but Negated only for a negated Region. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Say in SelectorMap's Javadoc that two equal 1-D SelectorMaps in series, both forward, simplify to a UnitMap, a C bug kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Compare exactly the SwitchMap outputs of the SelectorMap tests from test_switchmap.rs, which are WinMap arithmetic exact in IEEE doubles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Pin with C stc.c's Simplify of a negated Stc, which moves the negation onto its encapsulated Region, and of an Stc mapped into another Frame, whose encapsulated and AstroCoords Regions it maps there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Take RegionStcOracleTest's refit of the Error Ellipse from the production code instead of a copy of bestEllipse's arithmetic: the Circle's fit itself, and, for the bound, the primary half-length and each point's secondary estimate from Ellipse.bestPrimaryAxis and Ellipse.secondaryEstimate, which bestEllipse now calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DidLSPfwbAELCxqtcAbPhR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.