Repository navigation
refactor(configs): store config secrets as SecretStr - #563
Merged
Merged
Conversation
HosseinNejatiJavaremi
added
area:configs
github-actions
Bot
added
documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Redis, Keycloak, MinIO, Vault and SQLAlchemy password/token fields use SecretStr, so repr(), str() and model_dump() mask them; use sites unwrap with get_secret_value(). POSTGRES_DSN is a non-str secret and keeps Field(repr=False). Updates tests, test helpers and config docs.
HosseinNejatiJavaremi
force-pushed
the
refactor/configs-secretstr
branch
from
November 2, 2026 10:29
cd5cdbd to
b34b166
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis, Keycloak, MinIO, Vault and SQLAlchemy password/token fields are
SecretStr, sorepr(),str()andmodel_dump()mask them; use sites unwrap withget_secret_value().POSTGRES_DSNis a non-str secret and keepsField(repr=False).Tests:
base_config.feature162/162,optional_dependencies.feature4/4; masking assertions now cover repr, str and model_dump_json; ruff and ty clean.Closes #561