Repository navigation
fix(sqlalchemy): preserve logic exceptions in atomic blocks - #572
Merged
HosseinNejatiJavaremi merged 1 commit intoNov 2, 2026
Merged
Conversation
The atomic decorator maps only SQLAlchemy failures to Database*Error and re-raises every other exception unchanged. A default nested failure stores the first exception and re-raises it at the outer boundary instead of DatabaseTransactionError; a failed rollback is logged without hiding it. Savepoints keep their isolation behavior. Updates tests, docs and the 5.28.0 changelog.
HosseinNejatiJavaremi
added
bug
github-actions
Bot
added
documentation
HosseinNejatiJavaremi
deleted the
fix/sqlalchemy-atomic-preserve-errors
branch
November 2, 2026 14:35
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic decorator now maps only
SQLAlchemyErrortoDatabase*Errorand re-raises logic exceptions unchanged. A default nested failure stores the first exception and re-raises it at the outer boundary;DatabaseTransactionErroris reserved for transaction failures. A failed rollback is logged without hiding the original error; savepoint isolation is unchanged.Tests: sqlite 102/102, postgres 90/90, mysql 58/58, multiple databases 24/24; ruff, ty and docs-check clean.
Includes the 5.28.0 changelog.
Closes #571