Skip to content

fix wireless-tag-wt32-sc01-plus - #764

Merged
KenVanHoeylandt merged 1 commit into
TactilityProject:mainfrom
Shadowtrance:wt32
Nov 19, 2026
Merged

KenVanHoeylandt merged 1 commit into
TactilityProject:mainfrom
Shadowtrance:wt32

Conversation

@Shadowtrance

@Shadowtrance Shadowtrance commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Just some minor fixes for this device i didn't even know was broken. 🤣
esp32-i8080 CS is optional instead of fatal if not defined
st7796-i8080 swap_color_bytes off for correct colours
switched to the more reliable ft5x06 touch driver

Summary by CodeRabbit

  • Compatibility
    • Updated touchscreen support for the WT32-SC01 Plus to use the FT5x06 controller.
  • Bug Fixes
    • Corrected color-byte handling for displays using the ST7796 I8080 interface.
  • Improvements
    • Chip-select configuration now supports panels without a chip-select line, including those with CS tied low. Unconfigured chip-select addresses are handled as having no chip select, while negative addresses remain invalid.

esp32-i8080 CS is optional instead of fatal if not defined
st7796-i8080 swap_color_bytes off for correct colours
switched to the more reliable ft5x06 touch driver
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The WT32-SC01 Plus configuration now selects FT5x06 for its touchscreen. I8080 chip-select handling now supports absent entries and addresses beyond the configured list by returning an empty pin spec. The ST7796 panel configuration disables hardware color-byte swapping.

Merge Risk: Low · up to 65c49

The WT32-SC01 Plus touchscreen may miss touches after sitting idle until it is touched again. Adding disable-monitor-timeout to the touch node fixes this; the other changes look sound.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix wireless-tag-wt32-sc01-plus" names the device that the PR changes, and the PR is a fix for that device. However, it does not say what was fixed. The changes cover three items: the ESP32…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix wireless-tag-wt32-sc01-plus" names the device that the PR changes, and the PR is a fix for that device. However, it does not say what was fixed. The changes cover three items: the ESP32 I8080 chip-select pin becomes optional instead of fatal when undefined, color-byte swapping is disabled for the ST7796 I8080 panel, and the touch driver switches from FT6x36 to FT5x06. The title is therefore partially related. It names a real part of the change but not the main point, so it is too broad to tell a reviewer what changed.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c288562-1a36-482c-a681-c49fceb04724
Commits

Reviewing files that changed from the base of the PR and between b2ab8cf and 65c49c5.

Files selected for processing: 6

  • Devices/wireless-tag-wt32-sc01-plus/module.yaml
  • Devices/wireless-tag-wt32-sc01-plus/wireless-tag,wt32-sc01-plus.dts
  • Drivers/st7796-i8080-module/source/st7796_i8080.cpp
  • Platforms/platform-esp32/bindings/espressif,esp32-i8080.yaml
  • Platforms/platform-esp32/include/tactility/drivers/esp32_i8080.h
  • Platforms/platform-esp32/source/drivers/esp32_i8080.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@KenVanHoeylandt
KenVanHoeylandt merged commit 8766542 into TactilityProject:main Nov 19, 2026
84 checks passed
@KenVanHoeylandt

Copy link
Copy Markdown
Contributor

Great, thanks!

@Shadowtrance
Shadowtrance deleted the wt32 branch November 19, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants