You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just some minor fixes for this device i didn't even know was broken. 🤣
esp32-i8080 CS is optional instead of fatal if not defined
st7796-i8080 swap_color_bytes off for correct colours
switched to the more reliable ft5x06 touch driver
Summary by CodeRabbit
Compatibility
Updated touchscreen support for the WT32-SC01 Plus to use the FT5x06 controller.
Bug Fixes
Corrected color-byte handling for displays using the ST7796 I8080 interface.
Improvements
Chip-select configuration now supports panels without a chip-select line, including those with CS tied low. Unconfigured chip-select addresses are handled as having no chip select, while negative addresses remain invalid.
esp32-i8080 CS is optional instead of fatal if not defined
st7796-i8080 swap_color_bytes off for correct colours
switched to the more reliable ft5x06 touch driver
The WT32-SC01 Plus configuration now selects FT5x06 for its touchscreen. I8080 chip-select handling now supports absent entries and addresses beyond the configured list by returning an empty pin spec. The ST7796 panel configuration disables hardware color-byte swapping.
Merge Risk: Low · up to 65c49
The WT32-SC01 Plus touchscreen may miss touches after sitting idle until it is touched again. Adding disable-monitor-timeout to the touch node fixes this; the other changes look sound.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix wireless-tag-wt32-sc01-plus" names the device that the PR changes, and the PR is a fix for that device. However, it does not say what was fixed. The changes cover three items: the ESP32…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix wireless-tag-wt32-sc01-plus" names the device that the PR changes, and the PR is a fix for that device. However, it does not say what was fixed. The changes cover three items: the ESP32 I8080 chip-select pin becomes optional instead of fatal when undefined, color-byte swapping is disabled for the ST7796 I8080 panel, and the touch driver switches from FT6x36 to FT5x06. The title is therefore partially related. It names a real part of the change but not the main point, so it is too broad to tell a reviewer what changed.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some minor fixes for this device i didn't even know was broken. 🤣
esp32-i8080 CS is optional instead of fatal if not defined
st7796-i8080 swap_color_bytes off for correct colours
switched to the more reliable ft5x06 touch driver
Summary by CodeRabbit