Skip to content

fix(conversions): reject empty negative binary input in bin_to_hexadecimal #15693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhumit267 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

fix(conversions): reject empty negative binary input in bin_to_hexadecimal #15693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion conversions/binary_to_hexadecimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ def bin_to_hexadecimal(binary_str: str) -> str:
Traceback (most recent call last):
...
ValueError: Empty string was passed to the function
>>> bin_to_hexadecimal('-')
Traceback (most recent call last):
...
ValueError: Non-binary value was passed to the function
>>> bin_to_hexadecimal(' - ')
Traceback (most recent call last):
...
ValueError: Non-binary value was passed to the function
"""
# Sanitising parameter
binary_str = str(binary_str).strip()
Expand All @@ -45,7 +53,7 @@ def bin_to_hexadecimal(binary_str: str) -> str:
raise ValueError("Empty string was passed to the function")
is_negative = binary_str[0] == "-"
binary_str = binary_str[1:] if is_negative else binary_str
if not all(char in "01" for char in binary_str):
if not binary_str or not all(char in "01" for char in binary_str):
raise ValueError("Non-binary value was passed to the function")

binary_str = (
Expand Down
Loading