Skip to content

fix(admin): leave comped and admin accounts out of the promo funnel - #145

Merged
kipavy merged 1 commit into
mainfrom
fix/funnel-exclude-comped
Nov 15, 2026
Merged

kipavy merged 1 commit into
mainfrom
fix/funnel-exclude-comped

Conversation

@kipavy

@kipavy kipavy commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The admin promo funnel (shown / clicked / activated, trials activated, trial→paid) now ignores events from comped (admin_override) and admin (is_admin) accounts. Those accounts are never offered trials, so their events can only come from internal testing, and they were skewing the numbers.

Tests

New overview_promo_funnel_ignores_comped_and_admin_accounts; cargo test promo_funnel passes (2/2) and cargo clippy --all-targets -D warnings is clean.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kipavy
kipavy merged commit cb47c72 into main Nov 15, 2026
1 check passed
@kipavy
kipavy deleted the fix/funnel-exclude-comped branch November 15, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant