Repository navigation
fix(billing): report no seat count for an uncapped team owner - #149
Merged
Merged
Conversation
/subscription-info filled seats with 3 when seat_count is NULL, so clients showed 3 seats for owners the server never caps (admin "unlimited seats").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /v1/billing/subscriptionfilledseatswith 3 whenever a Teams/Business owner hadseat_count = NULL. NULL is what the admin "unlimited seats" option stores, andowner_seat_capalready treats it as uncapped (effective_seats: null). Clients sawseats: 3and showed 3 seats.seatsis now sent as stored, so it isnullfor an uncapped owner.seatsis null.seat_count = NULL; any that did would now read as unlimited, which matches what the server enforces.Pairs with VoltiusApp/voltius (app readout) and VoltiusApp/web (portal plan card).
Tests:
team_owner_without_seat_count_reports_unlimited; billing tests and clippy-D warningspass.