Skip to content

fix(billing): report no seat count for an uncapped team owner - #149

Merged
kipavy merged 1 commit into
mainfrom
fix/unlimited-seats-readout
Nov 15, 2026
Merged

kipavy merged 1 commit into
mainfrom
fix/unlimited-seats-readout

Conversation

@kipavy

@kipavy kipavy commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

GET /v1/billing/subscription filled seats with 3 whenever a Teams/Business owner had seat_count = NULL. NULL is what the admin "unlimited seats" option stores, and owner_seat_cap already treats it as uncapped (effective_seats: null). Clients saw seats: 3 and showed 3 seats.

seats is now sent as stored, so it is null for an uncapped owner.

  • App 0.75.x (with feat(app): show team seats in invite surfaces, ∞ when unlimited voltius#882) shows ∞ in account settings as soon as this is deployed.
  • Apps older than 0.75.0 show no seat count there instead of a wrong 3.
  • The app's buy-seats pricing already falls back to 3 when seats is null.
  • Assumes no paying account has seat_count = NULL; any that did would now read as unlimited, which matches what the server enforces.

Pairs with VoltiusApp/voltius (app readout) and VoltiusApp/web (portal plan card).

Tests: team_owner_without_seat_count_reports_unlimited; billing tests and clippy -D warnings pass.

/subscription-info filled seats with 3 when seat_count is NULL, so clients
showed 3 seats for owners the server never caps (admin "unlimited seats").
@kipavy
kipavy merged commit ff5e898 into main Nov 15, 2026
1 check passed
@kipavy
kipavy deleted the fix/unlimited-seats-readout branch November 15, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant